[Merge] lp:~michael-sheldon/webbrowser-app/simplify-address-bar into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Wed Aug 27 14:42:42 UTC 2014


Review: Needs Fixing

In simplifyUrl(…):

 - there are several calls to url.toString(), you might want to define a var that contains its value

 - if(hasProtocol) : missing whitespace before the opening parenthesis

 - domain.replace("www.", "") : this should happen only if "www." is at the beginning of the domain (e.g. "http://www.com" should not return "com" as a domain, you could add a test case for that)

-- 
https://code.launchpad.net/~michael-sheldon/webbrowser-app/simplify-address-bar/+merge/232384
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list