[Merge] lp:~thomas-voss/trust-store/fix-1356343 into lp:trust-store

Seth Arnold seth.arnold at canonical.com
Wed Aug 20 02:19:00 UTC 2014


Review: Needs Information

Something I really don't understand about core::trust::AppIdFormattingTrustAgent::authenticate_request_with_parameters(); it looks like it would match strings named e.g. "foo_bar" and "foo_bar_10", and it looks like it would return different things ("foo" vs "foo_bar") if I've read it correctly.

Does it make sense to check for the two-underscore naming style before checking for the one-underscore name?
-- 
https://code.launchpad.net/~thomas-voss/trust-store/fix-1356343/+merge/231369
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~thomas-voss/trust-store/fix-1356343 into lp:trust-store.



More information about the Ubuntu-reviews mailing list