[Merge] lp:~laney/platform-api/1350874 into lp:platform-api

Iain Lane iain at orangesquash.org.uk
Mon Aug 18 11:06:27 UTC 2014


Iain Lane has proposed merging lp:~laney/platform-api/1350874 into lp:platform-api.

Commit message:
Fix error by pulling out and sharing a struct instead of defining it twice.

Requested reviews:
  Thomas Voß (thomas-voss)
  Ubuntu Phablet Team (phablet-team)
Related bugs:
  Bug #1350874 in platform-api (Ubuntu): "/usr/include/ubuntu/application/ui/input/event_deprecated.h:79:24: error: redefinition of ‘struct PointerCoordinate’"
  https://bugs.launchpad.net/ubuntu/+source/platform-api/+bug/1350874

For more details, see:
https://code.launchpad.net/~laney/platform-api/1350874/+merge/231171

Pull out PointerCoordinate struct shared between two files

structs have file scope. This means that a struct declared within a struct is
still visible outside it. In this case event_deprecated.h is included into
event.h and they both define an identical struct called PointerCoordinate.

Pull the definition out and share it. This does not add new API due to the
scoping rule mentioned previously.
-- 
https://code.launchpad.net/~laney/platform-api/1350874/+merge/231171
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~laney/platform-api/1350874 into lp:platform-api.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 3393 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140818/c1b340de/attachment.diff>


More information about the Ubuntu-reviews mailing list