[Merge] lp:~abreu-alexandre/webbrowser-app/filter-session-storage-url-save into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Mon Aug 18 10:26:01 UTC 2014


Review: Needs Fixing

9	+        onUrlChanged: {
10	+            if (url.length === 0 || url === 'about:blank') {
11	+                return;
12	+            }
13	+            if (popupRedirectionUrlPrefix.length !== 0
14	+                    && url.indexOf(popupRedirectionUrlPrefix) === 0) {
15	+                return;
16	+            }
17	+            session.save()
18	+        }


This is missing a "var url = webapp.currentWebview.url;" at the beginning of the onUrlChanged handler. Otherwise you’re testing the 'url' property, which is not equivalent to the current webview’s URL in all cases.
-- 
https://code.launchpad.net/~abreu-alexandre/webbrowser-app/filter-session-storage-url-save/+merge/230875
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list