[Merge] lp:~dbarth/webbrowser-app/webapp-override into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Mon Aug 18 06:55:26 UTC 2014


Review: Needs Fixing

Thanks for the update. One more thing that needs to be fixed: in src/app/webcontainer/WebappContainerWebview.qml, you’re referring to 'root', which is not defined there, but in a file that instantiates WebappContainerWebview. This breaks encapsulation, and makes the code hard to maintain. What you need to do is add a 'webviewOverrideFile' property to WebappContainerWebview, and where it is instatiated propagate its value accordingly.
-- 
https://code.launchpad.net/~dbarth/webbrowser-app/webapp-override/+merge/229589
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list