[Merge] lp:~vorlon/ubuntu/utopic/apport/lp.1354318 into lp:~ubuntu-core-dev/ubuntu/utopic/apport/ubuntu

Brian Murray brian at ubuntu.com
Fri Aug 15 14:33:51 UTC 2014


> On Sat, Aug 09, 2014 at 06:06:33AM -0000, Steve Langasek wrote:
> > On Fri, Aug 08, 2014 at 12:51:51PM -0000, Evan Dandrea wrote:
> >
> > > > +        if r.get('ProblemType', '') != 'Crash' and 'ExecutablePath' not
> in r:
> > > > +            print('  skipping, not a crash')
> >
> > > Why? What about RecoverableProblem?
> >
> > This isn't a change to the code, only reindenting.  I don't know why the
> > handling is limited to these types.
> 
> I modified this check in upstream apport revision 2803 which was
> uploaded to Utopic. See http://launchpad.net/bugs/1319099. Additionally,
> we've looked at RecoverableProblems in the Error Tracker from the phone
> which resulted in bug 1350536.

RecoverableProblems have a ProblemType of RecoverableProblem so not Crash, but have an Executable Path in the report so will be uploaded. Perhaps the 'not a crash' string should be clarified though.
-- 
https://code.launchpad.net/~vorlon/ubuntu/utopic/apport/lp.1354318/+merge/230083
Your team Ubuntu Core Development Team is subscribed to branch lp:~ubuntu-core-dev/ubuntu/utopic/apport/ubuntu.



More information about the Ubuntu-reviews mailing list