[Merge] lp:~artmello/webbrowser-app/webbrowser-app-swipe_to_delete into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Thu Aug 14 13:20:26 UTC 2014


Looks good now, thanks for the update.

One more thing I just noticed: when removing the last entry from the expanded history view (for a given domain), the view is closed. However when removing the last domain in the basic history view (list of domains), the view is not closed, it just sits there, empty. Do you think we could make the view auto-close when the last domain is removed? Maybe something like this:

  ListView {
    id: domainsListView
    onCountChanged: {
      if (count == 0) {
        historyView.done()
      }
    }
  }
-- 
https://code.launchpad.net/~artmello/webbrowser-app/webbrowser-app-swipe_to_delete/+merge/229550
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list