[Merge] lp:~jani/goget-ubuntu-touch/download-only into lp:goget-ubuntu-touch

Sergio Schvezov sergio.schvezov at canonical.com
Tue Aug 5 16:39:39 UTC 2014


minor comment

Diff comments:

> === modified file 'ubuntu-device-flash/args.go'
> --- ubuntu-device-flash/args.go	2014-07-09 08:52:49 +0000
> +++ ubuntu-device-flash/args.go	2014-08-05 14:39:30 +0000
> @@ -32,6 +32,7 @@
>  	Channel       string `long:"channel" description:"Specify an alternate channel"`
>  	Device        string `long:"device" description:"Specify the device to flash"`
>  	DeviceTarball string `long:"device-tarball" description:"Specify a local device tarball to override the one from the server (using official Ubuntu images with custom device tarballs)"`
> +	DownloadOnly  bool   `long:"download-only" description:"Only download tarballs, do not push to the device."`
>  	Serial        string `long:"serial" description:"Serial of the device to operate"`
>  	Server        string `long:"server" description:"Use a different image server"`
>  	CleanCache    bool   `long:"clean-cache" description:"Cleans up cache with all downloaded bits"`
> 
> === modified file 'ubuntu-device-flash/main.go'
> --- ubuntu-device-flash/main.go	2014-07-09 08:52:49 +0000
> +++ ubuntu-device-flash/main.go	2014-08-05 14:39:30 +0000
> @@ -160,6 +160,13 @@
>  	for _, file := range signFiles {
>  		go bitDownloader(file, files, args.Server, cacheDir)
>  	}
> +	if args.DownloadOnly {
> +		for i := 0; i < totalFiles; i++ {
> +			<-files
> +		}
> +		log.Printf("Downloaded files, exiting without flashing as requested.\n")

Since downloading for later can you add a comment on what channel and revision to set to use this?

> +		os.Exit(0)
> +	}
>  	if args.Bootstrap {
>  		var downloadedFiles []Files
>  		for i := 0; i < totalFiles; i++ {
> 


-- 
https://code.launchpad.net/~jani/goget-ubuntu-touch/download-only/+merge/229632
Your team Ubuntu Phablet Team is subscribed to branch lp:goget-ubuntu-touch.



More information about the Ubuntu-reviews mailing list