[Merge] lp:~manjo/ubuntu/trusty/systemd/HP-m800 into lp:ubuntu/trusty/systemd
Martin Pitt
martin.pitt at ubuntu.com
Tue Aug 5 15:26:19 UTC 2014
Review: Needs Fixing
For efficiency reasons I'd like to avoid calling the two shells and the cat on every platform. This can be done more efficiently with
SUBSYSTEM=="input", KERNEL=="event*", SUBSYSTEMS=="platform", KERNELS=="gpio_keys.12", ATTRS{keys}=="116", PROGRAM="/bin/cat /proc/device-tree/model", RESULT=="HP ProLiant m800*", TAG+="power-switch"
Then on any system which doesn't have a gpio_keys.12 there will be no additional program calls at all, and on that device it's a single cat (and if the file isn't pesent it'll just fail and RESULT will be empty).
Can you please double-check that?
--
https://code.launchpad.net/~manjo/ubuntu/trusty/systemd/HP-m800/+merge/227649
Your team Ubuntu branches is requested to review the proposed merge of lp:~manjo/ubuntu/trusty/systemd/HP-m800 into lp:ubuntu/trusty/systemd.
More information about the Ubuntu-reviews
mailing list