[Merge] lp:~osomon/webbrowser-app/dialog-rotation-dimensions into lp:webbrowser-app
Olivier Tilloy
olivier.tilloy at canonical.com
Mon Aug 4 09:48:21 UTC 2014
Olivier Tilloy has proposed merging lp:~osomon/webbrowser-app/dialog-rotation-dimensions into lp:webbrowser-app.
Commit message:
Factor out some common code in a ModalDialog component,
and fix dialog auto-rotation and dimensions.
Requested reviews:
Ubuntu Phablet Team (phablet-team)
Related bugs:
Bug #1351922 in webbrowser-app: "JS dialogs are rotated 180° when the device is in landscape mode"
https://bugs.launchpad.net/webbrowser-app/+bug/1351922
For more details, see:
https://code.launchpad.net/~osomon/webbrowser-app/dialog-rotation-dimensions/+merge/229421
--
https://code.launchpad.net/~osomon/webbrowser-app/dialog-rotation-dimensions/+merge/229421
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~osomon/webbrowser-app/dialog-rotation-dimensions into lp:webbrowser-app.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 3676 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140804/d8008461/attachment.diff>
More information about the Ubuntu-reviews
mailing list