[Merge] lp:~kai-mast/friends/keep-mentions into lp:friends

Robert Bruce Park robert.park at canonical.com
Tue Apr 22 20:33:18 UTC 2014


Hi Kai, I have a couple concerns about this branch:

* I'd like to see the 'counts' dict be a defaultdict. Then you save having to check whether the stream is already present or not. 

* I see a lot of deletions from the testsuite and no additions. Any way you can flesh out the tests to cover the new behavior?
-- 
https://code.launchpad.net/~kai-mast/friends/keep-mentions/+merge/204784
Your team Super Friends is requested to review the proposed merge of lp:~kai-mast/friends/keep-mentions into lp:friends.



More information about the Ubuntu-reviews mailing list