[Merge] lp:~intelomkar/ubuntu/saucy/nemo/nemo-1.8.4-1 into lp:ubuntu/saucy/nemo

[Omkarnath]

Omkarnath has proposed merging lp:~intelomkar/ubuntu/saucy/nemo/nemo-1.8.4-1 into lp:ubuntu/saucy/nemo.

Requested reviews:
  Ubuntu Development Team (ubuntu-dev)

For more details, see:
https://code.launchpad.net/~intelomkar/ubuntu/saucy/nemo/nemo-1.8.4-1/+merge/215954

fixed an issue that would cause Nemo to get into not responding state.

steps to reproduce:
At any point when location bar is in breadcrumbs mode, press CTRL+L to
switch to text mode.
Press ESC to revert back to breadcrumbs mode.
Try to switch mode again using Toggle button right next to breadcrumbs.
Nemo should be in non-responding mode.
(there is one infinite loop running at back due to inconsistency)

fix:
navigation_bar_cancel_callback was calling nemo_toolbar_set_show_location_entry
which in turns changes toolbar to breadcrumbs mode. Changed it to call
toggle_location_entry_setting instead. This sets the mode and takes care
of other things like saving preferences too.

This issue is only present in official packages which are older versions.
I found newer versions have moved on to much different approach.


-- 
https://code.launchpad.net/~intelomkar/ubuntu/saucy/nemo/nemo-1.8.4-1/+merge/215954
Your team Ubuntu Development Team is requested to review the proposed merge of lp:~intelomkar/ubuntu/saucy/nemo/nemo-1.8.4-1 into lp:ubuntu/saucy/nemo.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1468 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140415/b20ca324/attachment-0001.diff>