[Merge] lp:~zulcss/nova/lxc into lp:~ubuntu-server-dev/nova/havana

Adam Gandelman adamg at ubuntu.com
Thu Sep 26 16:48:39 UTC 2013


Review: Needs Fixing

Can you please cleanup pep8 and add unit tests?

I'm concerned shipping this before its even been proposed upstream, especially if its not shipping without any test coverage.  I'd be okay if it had tests run at package build time and you also integrated this driver as something we deploy and exercise as part of lp:openstack-ubuntu-testing. 
-- 
https://code.launchpad.net/~zulcss/nova/lxc/+merge/187796
Your team Ubuntu Server Developers is subscribed to branch lp:~ubuntu-server-dev/nova/havana.



More information about the Ubuntu-reviews mailing list