[Merge] lp:~mfisch/ubuntu/saucy/ubuntu-touch-customization-hooks/add-scripts into lp:ubuntu/ubuntu-touch-customization-hooks

Loïc Minier lool at dooz.org
Wed Sep 11 01:07:24 UTC 2013


1) Hmm not quite sure about keeping /etc/init/pre-session-custom-scripts.conf running /etc/pre-session.d scripts if /custom is present; just add more plain upstart jobs if you need more.  The pre-session.d hook was specifically meant for unanticipated /custom stuff.

2) +start on startup seems incorrect for the setenv stuff; it specifically needs to happen before dbus starts spawning tons of stuff, if you disconnect it from "starting dbus", you can't guarantee it will be done by the time some dbus-spawned programs launch (or dbus itself)

3) cp -a /custom/etc/dconf_source/* /custom/etc/dconf eventually wont work since /custom will be read-only; I guess the idea was to defer dconf update til on the device, but that's not possible into /custom with system-image; can't you pre-run dconf update when creating custom.tgz?
-- 
https://code.launchpad.net/~mfisch/ubuntu/saucy/ubuntu-touch-customization-hooks/add-scripts/+merge/184880
Your team Ubuntu branches is subscribed to branch lp:ubuntu/ubuntu-touch-customization-hooks.



More information about the Ubuntu-reviews mailing list