[Merge] lp:~timchen119/gnome-control-center/gnome-control-center.precise.lp1244065 into lp:ubuntu/precise-proposed/gnome-control-center
Sebastien Bacher
seb128 at ubuntu.com
Wed Oct 30 00:40:28 UTC 2013
Review: Needs Fixing
Thank you for the work there, some notes about your work:
- could you edit the patch to add the info you added to the trunk version (bug reference, description, etc)
- the bug report needs SRU impact/test case/regression potential (see https://wiki.ubuntu.com/StableReleaseUpdates for details)
- could you ask the SRU team (https://launchpad.net/~ubuntu-sru/+members#active) if that's fine to add those options in a stable update?
- you are targetting the wrong vcs, lp:~ubuntu-desktop/gnome-control-center/precise is the packaging branch for the LTS
Otherwise the changes look fine for an upload
--
https://code.launchpad.net/~timchen119/gnome-control-center/gnome-control-center.precise.lp1244065/+merge/192472
Your team Ubuntu branches is subscribed to branch lp:ubuntu/precise-proposed/gnome-control-center.
More information about the Ubuntu-reviews
mailing list