[Merge] lp:~brunonova/software-properties/update-apt-on-exit into lp:software-properties

[Bruno Nova]

Bruno Nova has proposed merging lp:~brunonova/software-properties/update-apt-on-exit into lp:software-properties.

Requested reviews:
  Ubuntu Core Development Team (ubuntu-core-dev)
Related bugs:
  Bug #782953 in software-center (Ubuntu): "Software Center doesn't detect changes in sources until update-apt-xapian-index is ran by cron"
  https://bugs.launchpad.net/ubuntu/+source/software-center/+bug/782953
  Bug #1075537 in software-properties (Ubuntu): "software-properties needs to automatically trigger a cache refresh after adding a repo"
  https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/1075537

For more details, see:
https://code.launchpad.net/~brunonova/software-properties/update-apt-on-exit/+merge/190498

Fixes Bug #1075537 (and, indirectly, Bug #782953 it seems).

The apt cache was not being updated on exit, because the "modified_sourceslist" variable in the file "softwareproperties/gtk/SoftwarePropertiesGtk.py" was not being set correctly (it was never set to True). This was fixed, I hope.
Tested in Ubuntu 13.04 by replacing the installed version of the file (in /usr/lib/python3/dist-packages/softwareproperties/gtk/SoftwarePropertiesGtk.py) with this new one. It worked in my tests (not many tests), and update dialog appeared on exit.

Apparently, this also fixes Bug #782953 in the Software Center.
When software-properties-gtk is run by Software Center, it "grabs" (and hides) the update dialog and shows the update progress inside the Software Center.
It, then, runs "update-apt-xapian-index" correctly.
-- 
https://code.launchpad.net/~brunonova/software-properties/update-apt-on-exit/+merge/190498
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~brunonova/software-properties/update-apt-on-exit into lp:software-properties.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 816 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20131010/ceb4f75b/attachment.diff>