[Merge] lp:~shawn111/alsa-driver/dkms-packaging into lp:~ubuntu-audio-dev/alsa-driver/dkms-packaging

[David Henningsson]

Review: Needs Information


Thanks for the patch!

I have the following review comments/question:

First, I wonder if this is the right place to put it. This way, the
auto-built packages on launchpad will have the modaliases, but manually
build dkms packages (using e g "make dkms-mkdeb-source-only") will not.

Is it possible for you to try to use Makefile instead of debian/rules to
incorporate this feature?

Second, according to dh_modaliases man page, "it extracts the modules'
modaliases from either the compile .ko files themselves (for packages
which ship them in compiled form, using modinfo)". Why do you use a sed
script at all if dh_modaliases can do that itself?

Also, do you know if dkms upstream has given this any thought? Generic
support for this in dkms would be the best, but I understand if this is
not doable, at least not in the short term.

-- 
https://code.launchpad.net/~shawn111/alsa-driver/dkms-packaging/+merge/189803
Your team Ubuntu Audio Development Team is subscribed to branch lp:~ubuntu-audio-dev/alsa-driver/dkms-packaging.