[Merge] lp:~smoser/software-properties/shortcut-refactor into lp:software-properties

Michael Vogt michaelvogt at imap.cc
Wed Oct 2 11:48:17 UTC 2013


On Tue, Oct 01, 2013 at 03:17:34AM -0000, Scott Moser wrote:
> The proposal to merge lp:~smoser/software-properties/shortcut-refactor into lp:software-properties has been updated.
> 
> Commit Message changed to:
> 
> Refactor ppa handling into generic 'shortcuts', add handler for cloud-archive
> 
> This re-factors the 'ppa:' handling into something more generic.
> Then, we add a handler for 'cloud-archive:<item>' where item is one of 'tools{,-updates,proposed}', or '<openstack-release>{,-updates,-proposed}.
> 
> fixes bug 1233486

Thanks for this branch! I looked over the code and it looks good,
thanks for the refactor, this made the concept nicer and more
generic. But it seems like the branch is breaking the tests, i.e. when
I run "python setup.py test" on my box I get some test failures.

Cheers,
 Michael

-- 
https://code.launchpad.net/~smoser/software-properties/shortcut-refactor/+merge/188500
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~smoser/software-properties/shortcut-refactor into lp:software-properties.



More information about the Ubuntu-reviews mailing list