[Merge] lp:~jderose/ubuntu/trusty/couchdb/1.5.0 into lp:ubuntu/couchdb

Dave Cottlehuber dch at jsonified.com
Sat Nov 30 22:01:22 UTC 2013


Review: Needs Fixing

Please add vendor information into default.ini.

See my comment on https://code.launchpad.net/~yolanda.robla/ubuntu/trusty/couchdb/add_distribution/+merge/195788, included here for simplicity:

Great idea -- luckily CouchDB already provides functionality to do this without needing an erlang patch;

You should use the dict `vendor` option and store this in the default.ini file. There are name and version files specifically for that.

# $SOURCE/etc/couchdb/default.ini.tpl.in
[vendor]
name = Ubuntu
version = Trusty 14.04

Obviously you have a better idea of what these fields should be than me.

You should get something like this back after installing CouchDB:

GET / HTTP/1.1
Accept: application/json
Accept-Encoding: gzip, deflate, compress
Content-Type: application/json; charset=utf-8
Host: localhost:5984
User-Agent: HTTPie/0.8.0-dev

HTTP/1.1 200 OK
Cache-Control: must-revalidate
Content-Length: 145
Content-Type: application/json
Date: Sat, 30 Nov 2013 21:14:03 GMT
Server: CouchDB/1.5.0 (Erlang OTP/R16B02)

{
    "couchdb": "Welcome",
    "version": "1.5.0"
    "uuid": "24ca0e5e74a4e40356e498dcfb0575b1",
    "vendor": {
        "name": "Ubuntu",
        "version": "Trusty-14.04"
    },
}

The UUID entry is unique per couchdb installation, its shown here for completeness but shouldn't be part of the ubuntu package.

A gentle reminder to all reviewers, Apache CouchDB would love to hear more from downstream / packaging teams. We're here to help you help us!
-- 
https://code.launchpad.net/~jderose/ubuntu/trusty/couchdb/1.5.0/+merge/197291
Your team Ubuntu branches is requested to review the proposed merge of lp:~jderose/ubuntu/trusty/couchdb/1.5.0 into lp:ubuntu/couchdb.



More information about the Ubuntu-reviews mailing list