[Merge] lp:~noskcaj/ubuntu/trusty/pyrocket/new-release into lp:ubuntu/pyrocket
Dmitry Shachnev
mitya57 at gmail.com
Wed Nov 20 10:17:25 UTC 2013
Review: Needs Fixing
Thanks for your work here.
- When does the source tarball come from? debian/watch is broken, and when I download v0.8.tar.gz from GitHub, it has differences with your branch (i.e. 40-rocketlauncher.rules is missing);
- "LP:#1055778" won't close the bug, you need a space after the colon;
- dh-python is not used unless you build-depend on it (and falls back to "old" dh_python2 provided by python-defaults). See the relevant logic in /usr/bin/dh_python2.
By the way, here is a debian/watch line that works with GitHub:
opts=filenamemangle=s/.*v(.*).tar.gz/pyrocket_$1.orig.tar.gz/ \
http://github.com/stadler/pyrocket/tags .*/archive/v(.*).tar.gz
--
https://code.launchpad.net/~noskcaj/ubuntu/trusty/pyrocket/new-release/+merge/195921
Your team Ubuntu branches is requested to review the proposed merge of lp:~noskcaj/ubuntu/trusty/pyrocket/new-release into lp:ubuntu/pyrocket.
More information about the Ubuntu-reviews
mailing list