[Merge] lp:~cwayne18/ubuntu/trusty/account-plugin-fitbit/qml-plugins into lp:ubuntu/account-plugin-fitbit

Ken VanDine ken.vandine at canonical.com
Tue Nov 5 15:36:35 UTC 2013


Review: Needs Fixing


You need to add a build depends for libonline-accounts-client-dev and a depends for qtdeclarative5-online-accounts-client0.1

debian/copyright
  W: account-plugin-fitbit source: missing-license-paragraph-in-dep5-copyright bsd-2-clause (paragraph at line 17)


Otherwise I think it looks good.
-- 
https://code.launchpad.net/~cwayne18/ubuntu/trusty/account-plugin-fitbit/qml-plugins/+merge/193870
Your team Ubuntu branches is subscribed to branch lp:ubuntu/account-plugin-fitbit.



More information about the Ubuntu-reviews mailing list