[Merge] lp:~gandelman-a/ubuntu-dev-tools/lp1183985 into lp:ubuntu-dev-tools

Adam Gandelman adam.gandelman at canonical.com
Fri May 24 20:07:34 UTC 2013


Adam Gandelman has proposed merging lp:~gandelman-a/ubuntu-dev-tools/lp1183985 into lp:ubuntu-dev-tools.

Requested reviews:
  Ubuntu Development Team (ubuntu-dev)
Related bugs:
  Bug #1183985 in ubuntu-dev-tools (Ubuntu): "backportpackage no longer honors '--dontsign' option"
  https://bugs.launchpad.net/ubuntu/+source/ubuntu-dev-tools/+bug/1183985

For more details, see:
https://code.launchpad.net/~gandelman-a/ubuntu-dev-tools/lp1183985/+merge/165693

Looks like --key and --dont-sign should be acting on the same destination but wasn't, resulting in do_backport()'s keyid either being the specified keyid or always None, causing the following check to always pass:

do_package(..., keyid, ...):
    ...
    # None: sign with the default signature. False: don't sign
    if keyid is not False:
    ...
-- 
https://code.launchpad.net/~gandelman-a/ubuntu-dev-tools/lp1183985/+merge/165693
Your team Ubuntu Development Team is requested to review the proposed merge of lp:~gandelman-a/ubuntu-dev-tools/lp1183985 into lp:ubuntu-dev-tools.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1157 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20130524/9cd09b93/attachment.diff>


More information about the Ubuntu-reviews mailing list