[Merge] lp:~psivaa/auto-upgrade-testing/bug1159671 into lp:auto-upgrade-testing

Paul Larson paul.larson at canonical.com
Wed Mar 27 18:27:19 UTC 2013


Review: Needs Fixing

82	-        self.distpackages = '/usr/lib/%s/dist-packages/' % self.default_version
83	-        self.stderr = open('/tmp/%s.stderr' % os.path.basename(__file__)[:-3],'w')
84	+        self.distpackages = []
85	+        for dist_path in sys.path:
86	+            if 'dist-packages' in dist_path:
One of the goals here was to specifically pick up the python standard libraries.  Restricting to dist-packages won't accomplish that unfortunately.

87	+                if dist_path[0:dist_path.find('dist-packages') + 13] \
I prefer to avoid magic numbers


-- 
https://code.launchpad.net/~psivaa/auto-upgrade-testing/bug1159671/+merge/155819
Your team Auto Upgrade Testing Developers is requested to review the proposed merge of lp:~psivaa/auto-upgrade-testing/bug1159671 into lp:auto-upgrade-testing.



More information about the Ubuntu-reviews mailing list