[Merge] lp:~dannymardini/update-manager/checkboxfix into lp:~ubuntu-core-dev/update-manager/precise

[Colin Watson]

Thanks for your branch.  Just a quick code review, aside from the
question of design review which I'll let somebody else weigh in on:

> === modified file 'UpdateManager/UpdateManager.py'
> --- UpdateManager/UpdateManager.py	2012-04-17 12:57:58 +0000
> +++ UpdateManager/UpdateManager.py	2013-06-29 18:54:23 +0000
> @@ -908,10 +908,10 @@
>        self.setBusy(True)
>        actiongroup = apt_pkg.ActionGroup(self.cache._depcache)
>        for pkg in self.list.pkgs[origin]:
> -          if pkg.marked_install or pkg.marked_upgrade:
> +          if (pkg.marked_install or pkg.marked_upgrade) and select_all == False:
>                #print "marking keep: ", pkg.name
>                pkg.mark_keep()
> -          elif not (pkg.name in self.list.held_back):
> +          elif not (pkg.name in self.list.held_back) and select_all == True:

Please use "not select_all" rather than "select_all == False", and
"select_all" rather than "select_all == True" - there's no need to
explicitly compare booleans against True and False in conditional
expressions.

Feature work must be done against the development release (currently
saucy), not against precise.  Changes which meet
https://wiki.ubuntu.com/StableReleaseUpdates might be backported later.
For update-manager, the branch to look at is
lp:~ubuntu-core-dev/update-manager/main.  It looks as though this
segment of code has been moved around and also somewhat differently
there, so you may want to look into whether your request has already
been fulfilled in saucy.

-- 
https://code.launchpad.net/~dannymardini/update-manager/checkboxfix/+merge/172206
Your team Ubuntu Core Development Team is subscribed to branch lp:~ubuntu-core-dev/update-manager/precise.