[Merge] lp:~evfool/software-properties/twolineitems into lp:software-properties

Robert Roth evfool at gmail.com
Wed Jun 19 19:55:30 UTC 2013


Robert Roth has proposed merging lp:~evfool/software-properties/twolineitems into lp:software-properties.

Requested reviews:
  Ubuntu Core Development Team (ubuntu-core-dev)
Related bugs:
  Bug #930827 in software-properties (Ubuntu): "PPAs displayed poorly in "Other Software""
  https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/930827

For more details, see:
https://code.launchpad.net/~evfool/software-properties/twolineitems/+merge/170435

This branch improves the display of Other sources with comments by wrapping them into two lines, the first one for everything else except the URL, and the second one with the URL. 
See comparison:
CUrrent layout : https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/930827/+attachment/2732465/+files/Screenshot%20at%202012-02-12%2004%3A11%3A00.png
Proposed layout : https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/930827/+attachment/2732467/+files/Screenshot%20at%202012-02-12%2004%3A10%3A58.png

In my opinion the proposed layout improves readability, reduces the cases when we need a horizontal scrollbar, and makes the commented sources representation consistent with the Partners and Independent items representation (at least in terms of line count, aka item height) 
-- 
https://code.launchpad.net/~evfool/software-properties/twolineitems/+merge/170435
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~evfool/software-properties/twolineitems into lp:software-properties.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1467 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20130619/2d94218a/attachment.diff>


More information about the Ubuntu-reviews mailing list