[Merge] lp:~evfool/software-properties/lp1170114 into lp:software-properties
Michael Vogt
michaelvogt at imap.cc
Wed Jun 19 06:46:27 UTC 2013
On Tue, Jun 18, 2013 at 07:52:30PM -0000, Robert Roth wrote:
> Robert Roth has proposed merging lp:~evfool/software-properties/lp1170114 into lp:software-properties.
>
> Requested reviews:
> Ubuntu Core Development Team (ubuntu-core-dev)
> Related bugs:
> Bug #1170114 in software-properties (Ubuntu): "Add --disable-component option"
> https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/1170114
>
> For more details, see:
> https://code.launchpad.net/~evfool/software-properties/lp1170114/+merge/170185
>
> As we have add-apt-repository as the command line tool for adding/removing/enabling/disabling PPAs and distro components, I would suggest removing the command-line switch for enabling a component from software-properties-gtk to avoid duplication of code and functionality within the same project.
Thanks Robert! I think removing duplication is a good idea, but
instead of removing it entirely I would suggest that we add a message
to the user what the replacement interface is what how its used.
Thanks,
Michael
--
https://code.launchpad.net/~evfool/software-properties/lp1170114/+merge/170185
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~evfool/software-properties/lp1170114 into lp:software-properties.
More information about the Ubuntu-reviews
mailing list