[Merge] lp:~robru/friends/avatar-cache into lp:friends

Robert Bruce Park robert.park at canonical.com
Tue Jun 18 22:11:24 UTC 2013


Robert Bruce Park has proposed merging lp:~robru/friends/avatar-cache into lp:friends.

Requested reviews:
  Ken VanDine (ken-vandine)

For more details, see:
https://code.launchpad.net/~robru/friends/avatar-cache/+merge/170206

Stop caching avatar URLs locally; change icon_uri model schema to contain the original URL rather than the local cache. Delete all avatar cache expiry logic. Move the avatar cache under /tmp so that the system will clear it at each boot. 

How to test this change:

1. build a package from this branch and install it.
2. delete ~/.local/share/resources/com.canonical.Friends.Streams
3. start friends-app
4. ensure that friends-app scrolls very smoothly through the list of tweets
5. watch out for notifications, ensure that the avatar icon appears in them. (maybe set com.canonical.friends.notifications to 'all' so that you're more likely to see a notification when you do a refresh). 

Oh, and of course, run 'make check' ;-)
-- 
https://code.launchpad.net/~robru/friends/avatar-cache/+merge/170206
Your team Super Friends is subscribed to branch lp:friends.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 23107 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20130618/2629c2b1/attachment-0001.diff>


More information about the Ubuntu-reviews mailing list