[Merge] lp:~gandelman-a/ubuntu/saucy/cinder/dependency_dep8_test into lp:~ubuntu-server-dev/cinder/havana
Adam Gandelman
adam.gandelman at canonical.com
Tue Jul 23 17:23:27 UTC 2013
Adam Gandelman has proposed merging lp:~gandelman-a/ubuntu/saucy/cinder/dependency_dep8_test into lp:~ubuntu-server-dev/cinder/havana.
Commit message:
Add dep8 test: cinder/debian/tests/cinder-scheduler-filter-deps
Requested reviews:
Ubuntu Server Developers (ubuntu-server-dev)
For more details, see:
https://code.launchpad.net/~gandelman-a/ubuntu/saucy/cinder/dependency_dep8_test/+merge/176441
Adds cinder/debian/tests/cinder-scheduler-filter-deps to catch entry point loading issues in the scheduler. These exceptions get caught and squashed in stevedore and do not prevent the scheduler from starting, so our current dep8 daemon test passes fine. However, these depedency issues prevent the scheduler from actually scheduling volume actions. Since the exception is never raised, this mocks the stevedore logger and looks for the pkg_resource error messages.
First time writing a DEP8, would appreciate some review.
--
https://code.launchpad.net/~gandelman-a/ubuntu/saucy/cinder/dependency_dep8_test/+merge/176441
Your team Ubuntu Server Developers is requested to review the proposed merge of lp:~gandelman-a/ubuntu/saucy/cinder/dependency_dep8_test into lp:~ubuntu-server-dev/cinder/havana.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 3078 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20130723/eb81bd8b/attachment-0001.diff>
More information about the Ubuntu-reviews
mailing list