[Merge] lp:~robru/friends/simplify-contacts into lp:friends

Robert Bruce Park robert.park at canonical.com
Tue Jul 23 08:23:27 UTC 2013


Robert Bruce Park has proposed merging lp:~robru/friends/simplify-contacts into lp:friends.

Commit message:
More explicit call signature for Base._push_to_eds.

Requested reviews:
  Ken VanDine (ken-vandine)

For more details, see:
https://code.launchpad.net/~robru/friends/simplify-contacts/+merge/176338

So, re-reviewing the code after the last merge, I realized that I could take it even a step further in simplification ;-)

Now instead of passing an obscure dict as the argument to _push_to_eds, I've broken that down into explicit arguments, so that the call signature is significantly more scrutible. Note how the three protocols that call _push_to_eds now have to supply significantly less boilerplate, and it reads much more clearly.
-- 
https://code.launchpad.net/~robru/friends/simplify-contacts/+merge/176338
Your team Super Friends is subscribed to branch lp:friends.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 19738 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20130723/3ba47a80/attachment-0001.diff>


More information about the Ubuntu-reviews mailing list