[Merge] lp:~laney/livecd-rootfs/omap4-install-reverted-stack into lp:livecd-rootfs
Iain Lane
iain at orangesquash.org.uk
Tue Jul 16 15:38:27 UTC 2013
Iain Lane has proposed merging lp:~laney/livecd-rootfs/omap4-install-reverted-stack into lp:livecd-rootfs.
Requested reviews:
Ubuntu Core Development Team (ubuntu-core-dev)
For more details, see:
https://code.launchpad.net/~laney/livecd-rootfs/omap4-install-reverted-stack/+merge/175046
On armhf+omap4, stop using the ubuntu-desktop task and use the metapackage instead
The task pulls in the X stack which the metapackage does not. We can take advantage of this to install the omap-revert X stack that's needed for these images.
I'm wondering if I should do either or both of
- Collapse the case into a single case "$ARCH+$SUBARCH" statement since it only cases for armhf+omap4
- Combine the add_package call with the existing place it's used further on in the script
Let me know what you think.
--
https://code.launchpad.net/~laney/livecd-rootfs/omap4-install-reverted-stack/+merge/175046
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~laney/livecd-rootfs/omap4-install-reverted-stack into lp:livecd-rootfs.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1230 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20130716/11dc7281/attachment-0001.diff>
More information about the Ubuntu-reviews
mailing list