[Merge] lp:~robru/friends/fix-instagram-avatars into lp:friends

Robert Bruce Park robert.park at canonical.com
Mon Jul 8 20:58:24 UTC 2013


Robert Bruce Park has proposed merging lp:~robru/friends/fix-instagram-avatars into lp:friends.

Commit message:
Fix Instagram's avatar logic.

Requested reviews:
  Ken VanDine (ken-vandine)

For more details, see:
https://code.launchpad.net/~robru/friends/fix-instagram-avatars/+merge/173595

In my "haste" to catch up on landing Instagram, I overlooked the fact that it was still using the old Avatar logic that we've since deprecated. 

This commit updates instagram to stop using the old avatar stuff, and also updates the tests to confirm that the correct data gets published into the model. 

I also cleaned up some unused imports/variables and some style issues as well.
-- 
https://code.launchpad.net/~robru/friends/fix-instagram-avatars/+merge/173595
Your team Super Friends is subscribed to branch lp:friends.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 5337 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20130708/746700a7/attachment-0001.diff>


More information about the Ubuntu-reviews mailing list