[Merge] lp:~dylanmccall/update-manager/refactored-cellareapackage into lp:update-manager

Dylan McCall dylanmccall at gmail.com
Fri Jan 25 23:00:31 UTC 2013


Dylan McCall has proposed merging lp:~dylanmccall/update-manager/refactored-cellareapackage into lp:update-manager.

Requested reviews:
  Ubuntu Core Development Team (ubuntu-core-dev)

For more details, see:
https://code.launchpad.net/~dylanmccall/update-manager/refactored-cellareapackage/+merge/145040

While playing with the package column (and pkg_area) in UpdatesAvailable.py, I noticed I was needing to perform shotgun surgery in order to make some small changes: there was a bunch of code in CellAreaPackage that depended on specifics of UpdatesAvailable's tree view. This branch contains a more generalized CellAreaPackage. It isn't exactly _portable_ at this stage, but I think it's a step in the right direction. The assumptions it continues to make are documented, and innocent changes in other parts of the program are less likely to break it. The output should be identical to the existing cell area.
-- 
https://code.launchpad.net/~dylanmccall/update-manager/refactored-cellareapackage/+merge/145040
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~dylanmccall/update-manager/refactored-cellareapackage into lp:update-manager.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 5674 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20130125/083f4cbe/attachment.diff>


More information about the Ubuntu-reviews mailing list