[Merge] lp:~javier.collado/ubuntu-test-cases/bug1087630 into lp:~ubuntu-server-dev/ubuntu-test-cases/server-tests-raring

Max Brustkern max.brustkern at canonical.com
Thu Jan 10 15:14:25 UTC 2013


Review: Needs Information

The [ "$?" -eq "0" ] isn't really necessary.  That's in the default preseed so that a latecommand will exist, and that particular command was chosen to avoid masking the exit status of the utah latecommand if no other latecommand is present.  If another latecommand is present, that doesn't really serve a purpose.  That said, it doesn't hurt anything either.

Also, /var/log/utah-install is used for other things which can come before or after this use.  It doesn't look to me like the current code will detect the correct line and not just the first line of the file, but I could be wrong about that.
-- 
https://code.launchpad.net/~javier.collado/ubuntu-test-cases/bug1087630/+merge/142161
Your team Ubuntu Server Developers is subscribed to branch lp:~ubuntu-server-dev/ubuntu-test-cases/server-tests-raring.



More information about the Ubuntu-reviews mailing list