[Merge] lp:~mterry/update-manager/toggle-fix into lp:update-manager

[Michael Terry]

Michael Terry has proposed merging lp:~mterry/update-manager/toggle-fix into lp:update-manager.

Requested reviews:
  Ubuntu Core Development Team (ubuntu-core-dev)
Related bugs:
  Bug #1129191 in update-manager (Ubuntu): "some updates can't be checked from the main list"
  https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/1129191

For more details, see:
https://code.launchpad.net/~mterry/update-manager/toggle-fix/+merge/149116

-Refactors the toggle-an-item logic from two code paths down to one code path
-Introduce a convenience method is_selected() to cover a common question asked about a package
-Fixes bug 1129191 by dropping "auto_fix=False, auto_inst=False" when marking a package from install.  These flags were inherited from the old "toggle_by_origin" method and seem to have been an optimization because we knew that all affected packages were from same PPA/origin and wouldn't need a fixer check.  But we can no longer make that same assumption.  Running the fixer makes the bug go away.
-- 
https://code.launchpad.net/~mterry/update-manager/toggle-fix/+merge/149116
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~mterry/update-manager/toggle-fix into lp:update-manager.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 4671 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20130218/b5cb4344/attachment.diff>