[Merge] lp:~dylanmccall/update-manager/bug-1111768 into lp:update-manager

[Dylan McCall]

Dylan McCall has proposed merging lp:~dylanmccall/update-manager/bug-1111768 into lp:update-manager.

Requested reviews:
  Ubuntu Core Development Team (ubuntu-core-dev)
Related bugs:
  Bug #1111768 in update-manager (Ubuntu): "Updates remain (unchecked) after changing software sources"
  https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/1111768

For more details, see:
https://code.launchpad.net/~dylanmccall/update-manager/bug-1111768/+merge/146051

This is my fix for bug #1111768. It ended up ballooning into a larger set of changes than I had anticipated. The bug is that now-unavailable updates would remain (just deselected) after clicking Settings and disabling a source, leading to some unexpected (and ugly) situations. In addressing the problem, I found that the architecture around UpdateManager.py was a little bit loopy so I did a little bit to try to clean that up. (Not a whole lot, mind, but enough to achieve what I wanted to achieve).

This led to me, incidentally, making UpdatesAvailable a dialog (instead of its own thing that looks like a Dialog). I needed to change the two labels (header and description) at the top of each dialog to allocate height better than they were doing, which fixed a surprisingly unreported issue where we had large empty spaces above the buttons on certain dialogs (like the Restart Required dialog). This did lead to some smallish visual changes which we should discuss. Most obviously, the font size for the header has decreased. (Either I can't figure out Pango+pygobject or there is nothing there _to_ figure out). The buttons in the UpdatesAvailable dialog have slightly different margins, now, but that makes them consistent with the other dialogs so I imagine that's a positive change :)

Screenshots of either version are listed here: http://people.ubuntu.com/~dylanmccall/screenshots/update-manager/bug-1111768/
(Unfortunately I forgot to change my GTK theme to Ambiance, but the differences are the same).
-- 
https://code.launchpad.net/~dylanmccall/update-manager/bug-1111768/+merge/146051
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~dylanmccall/update-manager/bug-1111768 into lp:update-manager.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 68780 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20130201/de0bb2fa/attachment-0001.diff>