[Merge] lp:~om26er/kubuntu-packaging/qtmultimedia_unittests into lp:~kubuntu-packagers/kubuntu-packaging/qtmultimedia-opensource-src

Dmitry Shachnev mitya57 at gmail.com
Wed Dec 11 10:01:36 UTC 2013


Review: Abstain

Thanks for working on it!

> cd tests/auto/unit/ && ( test -e Makefile || qmake unit.pro -o Makefile ) && make -f Makefile check

That looks quite complicated. Take a look at i.e. qtsvg, where a simple dh_auto_test worked (though we explicitly told qmake to enable tests).

dh_auto_test is usually better because it takes care of things like DEB_BUILD_OPTIONS=nocheck.

P.S. Special thanks for adding bug numbers (though you may also want to use the DEP-3 format).
-- 
https://code.launchpad.net/~om26er/kubuntu-packaging/qtmultimedia_unittests/+merge/198387
Your team Kubuntu Packagers is subscribed to branch lp:~kubuntu-packagers/kubuntu-packaging/qtmultimedia-opensource-src.



More information about the Ubuntu-reviews mailing list