[Merge] lp:~zulcss/keystone/icehouse-ftbfs into lp:~ubuntu-server-dev/keystone/icehouse

James Page james.page at ubuntu.com
Tue Dec 3 17:49:16 UTC 2013


Review: Needs Fixing

Hey Chuck

Some comments

1) debian/patches/ubuntu-test-overrides.patch

This has changed but I don't see why - could you add some patch headers to explain why this is required

(patch headers for the fix-ubuntu-tests would be nice as well)

2) clean

As we create things in d/rules, we need to clean them up as well (override_dh_clean)

specifically testrepository data and debian/tmp/keystone - I suspect others as well.
-- 
https://code.launchpad.net/~zulcss/keystone/icehouse-ftbfs/+merge/197559
Your team Ubuntu Server Developers is subscribed to branch lp:~ubuntu-server-dev/keystone/icehouse.



More information about the Ubuntu-reviews mailing list