[Merge] lp:~racb/ubuntu/saucy/autopkgtest/lxc into lp:ubuntu/autopkgtest
Jean-Baptiste Lallement
jean-baptiste at ubuntu.com
Thu Aug 29 10:38:34 UTC 2013
Review: Needs Fixing
Thanks for your work!
I tested the following scenarios:
- i386 / amd64
- test package from dsc and source tree
- unbuilt tree and binary package
- clone mode, as well as options ephemeral and eatmydata
Overall it works fine but:
1. If the base container is not created from an ubuntu-cloud template (i.e debootstrap based), the driver goes to an infinite wait loop. It should fail gracefully in that case
2. The requirement for a cloud template means that the usage of this driver is limited to Ubuntu. Using any type of lxc container would allow to run tests in LXC on Debian for example.
3. This requirement is not documented
4. More generally there is no man page for this driver while there are for the other drivers
5. If eatmydata is not installed into the container and the driver is invoked with option --eatmydata then it crashes with
lxc-attach: No such file or directory - failed to exec 'eatmydata'
<VirtSubproc>: failure: (down) mkdir failed (exit status 255)
* It should either:
- Fail gracefully,
- or install eatmydata if not installed (but an implicit installation might be confusing and affect the test)
- or run without eatmydata (and display a warning)
I think at least 1, 3 and 5 should be fixed
--
https://code.launchpad.net/~racb/ubuntu/saucy/autopkgtest/lxc/+merge/172856
Your team Ubuntu branches is requested to review the proposed merge of lp:~racb/ubuntu/saucy/autopkgtest/lxc into lp:ubuntu/autopkgtest.
More information about the Ubuntu-reviews
mailing list