[Merge] lp:~albertsmuktupavels/xorg-server/fix-no-devices-detected-for-seats-other-than-seat0 into lp:ubuntu/xorg-server

a7x ubuntu-a7x at scientician.org
Tue Aug 6 21:18:27 UTC 2013


Review: Approve

I haven't tested it, but the changes look good enough to me.  (I don't have commit privileges, so someone official will also have to approve it.)

I have some minor nits about the patch header:
  * I'm not sure if people use automated tools to process the patch headers, but if they do, then it might be better to use Bug instead of Origin for the upstream bug URL.
  * I think it'd be better to keep the Subject and From lines from the original patch.
  * It'd be nice to use Origin to store a direct link to the original patch.
  * It'd be nice to include the Fedora bug URL.

For example:

From: Laércio de Sousa <lbsousajr at gmail.com>
Subject: xf86Bus.c: go further with legacy PCI bus probe for non-seat0 seats.
Origin: https://bugs.freedesktop.org/attachment.cgi?id=82364
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66851
Bug-Fedora: https://bugzilla.redhat.com/show_bug.cgi?id=962907

-- 
https://code.launchpad.net/~albertsmuktupavels/xorg-server/fix-no-devices-detected-for-seats-other-than-seat0/+merge/178795
Your team Ubuntu branches is requested to review the proposed merge of lp:~albertsmuktupavels/xorg-server/fix-no-devices-detected-for-seats-other-than-seat0 into lp:ubuntu/xorg-server.



More information about the Ubuntu-reviews mailing list