[Merge] lp:~sjakthol/software-properties/fix-1111291 into lp:software-properties

Michael Vogt michaelvogt at imap.cc
Tue Apr 9 05:41:11 UTC 2013


On Mon, Apr 08, 2013 at 12:17:22PM -0000, Sami Jaktholm wrote:
> The related bug report shows that the fallback code is activated due to invalid response (http.client.BadStatusLine: ''). Looking at the urrlib.request code around the exception it only seems to convert socket.error to URLError but exceptions from httplib propagate all the way back to clients. These exceptions then trigger the pycurl code that fails in python3.
> 
> But anyways, I'll change this to fit your suggestion (it's way cleaner than the current try/except mess).

Great! Thanks a lot and let me know once the merge proposal is updated :)

-- 
https://code.launchpad.net/~sjakthol/software-properties/fix-1111291/+merge/157514
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~sjakthol/software-properties/fix-1111291 into lp:software-properties.



More information about the Ubuntu-reviews mailing list