[Merge] lp:~evfool/software-properties/lp1036588 into lp:software-properties

Robert Roth evfool at gmail.com
Fri Sep 7 21:07:21 UTC 2012


Robert Roth has proposed merging lp:~evfool/software-properties/lp1036588 into lp:software-properties.

Requested reviews:
  Ubuntu Core Development Team (ubuntu-core-dev)
Related bugs:
  Bug #1036588 in software-properties (Ubuntu): "software-properties-kde crashed with NameError in select_mirror(): global name 'QString' is not defined"
  https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/1036588

For more details, see:
https://code.launchpad.net/~evfool/software-properties/lp1036588/+merge/123366

Remove unnecessary QString constructor causing the crash, as the interpreter is python3, so QString is undefined, and using native python str should work[1]

[1] http://wiki.python.org/moin/PortingPythonToPy3k/PyQt4
-- 
https://code.launchpad.net/~evfool/software-properties/lp1036588/+merge/123366
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~evfool/software-properties/lp1036588 into lp:software-properties.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 591 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20120907/84cd7a85/attachment.diff>


More information about the Ubuntu-reviews mailing list