[Merge] lp:~andrea.corbellini/software-properties/fix-621977 into lp:software-properties

Robert Roth evfool at gmail.com
Wed Nov 21 08:10:23 UTC 2012

Review: Approve

The patch looks fine with one minor detail: lots of unchanged lines are added to the diff (probably because tab/spaces usage - whitespace differences). It would be nice if you could set up your editor to use spaces instead of tabs (I think software-properties uses spaces instead of tabs) to avoid harder-to-review diffs, because the reviewer has to filter the real changes.

Other than that: nice solution to comment the source line by default, but leave an option to enable the source with the same command.
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~andrea.corbellini/software-properties/fix-621977 into lp:software-properties.

More information about the Ubuntu-reviews mailing list