[Merge] lp:~vorlon/update-notifier/lp.876298 into lp:update-notifier

Steve Langasek steve.langasek at canonical.com
Tue Mar 27 06:16:18 UTC 2012


On Fri, Mar 23, 2012 at 09:16:20AM -0000, Michael Vogt wrote:
> I commited some basic tests to lp:~mvo/update-notifier/lp.876298/ mostly
> because I wanted to make sure that I don't break stuff where I changed
> stuff.  I also did some code changes and tried to cover them with tests so
> that its safe.  None of the code changes is really critical, look at them
> and pick the bits you like and ignore the others :) I hope they all make
> sense but to a certain extend its a matter of preference.  Taking the
> tests would be nice though they should work regardless of the code changes
> I made.

Thanks, I've merged these changes into trunk now.  (Well, this is an
overloaded MP now, isn't it?)

> Feedback very welcome, it would be really nice if we had a test for the
> process_download_requests() too, but I have not looked what this involves,
> probably a bit of "from mock import Mock,patch" to patch some of the
> methods like urlretrieve() that we want to have mocks.

I haven't had a chance to look at adding these tests yet. :/

We also don't have counter-based aging of failures yet.  I guess we need to
get that sorted before landing this feature?

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org

https://code.launchpad.net/~vorlon/update-notifier/lp.876298/+merge/98487
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~vorlon/update-notifier/lp.876298 into lp:update-notifier.



More information about the Ubuntu-reviews mailing list