[Merge] lp:~geoubuntu/ubuntu/lucid/tvtime/tvtime.fix-715242 into lp:ubuntu/lucid/tvtime

[Pojar George]

Pojar George has proposed merging lp:~geoubuntu/ubuntu/lucid/tvtime/tvtime.fix-715242 into lp:ubuntu/lucid/tvtime.

Requested reviews:
  Ubuntu Development Team (ubuntu-dev)
Related bugs:
  Bug #715242 in tvtime (Ubuntu Lucid): "TVTime generates unwanted L_Shift key press events"
  https://bugs.launchpad.net/ubuntu/lucid/+source/tvtime/+bug/715242

For more details, see:
https://code.launchpad.net/~geoubuntu/ubuntu/lucid/tvtime/tvtime.fix-715242/+merge/96975

Use XScreenSaverExtension instead of typing text via Xtest (LP: #715242)

SRU test case:

1. Install and run tvtime
2. Start xev in a terminal and click on it
3. Watch events appearing although you are not doing anything
4. Stop xev and tvtime

With the proposed version of tvtime you will not see events in xev.

====Original Report====

[Impact]
TVTime's method to inhibit the screensaver implicates with the systems' normal usage (random shift key presses that make the shift key get "stuck" for 60 seconds: https://bugs.launchpad.net/ubuntu/+bug/588473).

[Development Fix]
There is a patch in Debian's bugzilla to "Use XScreenSaverExtension instead of typing text via XTest": http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=458041.

[Stable Fix]
As above.

[Test Case]
1. Install and run tvtime
2. Start xev in a terminal and click on it
3. Watch events appearing although you are not doing anything
4. Stop xev and tvtime

[Regression Potential]
Low. The fix has been in every-day use by many users of oneiric for a while.

[Original Report]
TVTime's method to inhibit the screensaver implicates with the systems' normal usage (random shift key presses that make the shift key get "stuck" for 60 seconds: https://bugs.launchpad.net/ubuntu/+bug/588473).

There is a patch in Debian's bugzilla to "Use XScreenSaverExtension instead of typing text via XTest": http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=458041.

This bug is very annoying and has serious implications in the systems' usability (often, the shift key gets stuck for more than 30 seconds that leads to unwanted permanent deletion of files, can't click links in browser without launching new windows, etc.)

tvtime 1.0.2 running on Ubuntu 10.04 x64.
-- 
https://code.launchpad.net/~geoubuntu/ubuntu/lucid/tvtime/tvtime.fix-715242/+merge/96975
Your team Ubuntu Development Team is requested to review the proposed merge of lp:~geoubuntu/ubuntu/lucid/tvtime/tvtime.fix-715242 into lp:ubuntu/lucid/tvtime.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 51573 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20120312/4a1944a8/attachment-0001.diff>