[Merge] lp:~nathwill/ubuntu/precise/pam/lp-110287 into lp:~ubuntu-core-dev/pam/ubuntu

Dmitrijs Ledkovs launchpad at surgut.co.uk
Mon Jun 11 02:10:22 UTC 2012


In a different review [0] Steve says:

"""
We want to:

 - add the PATH variable on new installs
 - on upgrades from versions of the package earlier than 1.1.3-7ubuntu2, *insert* /usr/local/games into the path - don't clobber the path, because if the local admin has modified the path, we don't want to override that setting.

I think the command to use for inserting the added path would be something like:

  sed -i -e'/^PATH / s,\(:/usr/games\),:/usr/local/games\1,' /etc/environment

And then the version number check needs to be fixed up as well, since currently the code only runs on new installs or when upgrading from a very, very ancient version of libpam-modules.
"""

Your code seems to address most of this, apart from fixing up the version check.

[0] https://code.launchpad.net/~dpolehn-gmail/ubuntu/precise/pam/fix-110287/+merge/92599
-- 
https://code.launchpad.net/~nathwill/ubuntu/precise/pam/lp-110287/+merge/100282
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~nathwill/ubuntu/precise/pam/lp-110287 into lp:~ubuntu-core-dev/pam/ubuntu.



More information about the Ubuntu-reviews mailing list