[Merge] lp:~mterry/auto-upgrade-testing/str-buffer into lp:auto-upgrade-testing

Colin Watson cjwatson at canonical.com
Fri Jul 6 20:31:19 UTC 2012


On Fri, Jul 06, 2012 at 05:36:26PM -0000, Michael Terry wrote:
>              interfaces = tempfile.NamedTemporaryFile()
> -            interfaces.write("""
> +            interfaces.write(bytes("""

You can use b"""...""" rather than bytes().  But this is really text
data, so I recommend instead simply opening the file in text mode:

  interfaces = tempfile.NamedTemporaryFile(mode="w+")

... and similarly for the other occurrences.  (You can add
encoding="UTF-8" if you need it, but it looks like you shouldn't.)

-- 
https://code.launchpad.net/~mterry/auto-upgrade-testing/str-buffer/+merge/113780
Your team Auto Upgrade Testing Developers is requested to review the proposed merge of lp:~mterry/auto-upgrade-testing/str-buffer into lp:auto-upgrade-testing.



More information about the Ubuntu-reviews mailing list