[Merge] lp:~evfool/software-properties/miscfixes2 into lp:software-properties

[Robert Roth]

The proposal to merge lp:~evfool/software-properties/miscfixes2 into lp:software-properties has been updated.

Description changed to:

This branch fixes the following bugs:
- Bug #496879 - returns non-0 result code from add-apt-repository whenever anything goes wrong, PPA can not be found, or signing  key can not be found
- Bug #779287 - API url changed to the URL of the pubic API
- Bug #489488 - partially fixes this by adding the PPA display name as deb-line comment, thus the displayname will be shown in software-properties instead of the long and confusing PPA url
- Bug #930624 - add a title (Add) to the add-dialog (instead of the default software-properties-gtk) and sets the image of the Add Source button to respect the buttons-have-icons setting
- Bug #599801 - sort software sources from the other software tab alphabetically by their description, this way we get a more deterministic ordering than the default, thus users will be able to find the source they are looking for faster.

I have also made the following changes:
- removed a duplicated utf8 method(the same method has been declared twice in apt-add-repo),
- added another testcase in testlp to test invalid repo is handled correctly (no PPA info is returned)
- updated the error handling (try .. except HTTPError, URLError statements have been removed) to work with new curl based PPA info fetching (as curl does not throw an exception, but the result code can be queried separately) by only accepting HTTP 200 OK for now, other "partially successful" HTTP response codes should be added as required
- added new testaptaddrepo tests for apt-add-repository sanity checks, to see if adding invalid repo returns non-0 result code and working commands return 0 result codes

For more details, see:
https://code.launchpad.net/~evfool/software-properties/miscfixes2/+merge/92611
-- 
https://code.launchpad.net/~evfool/software-properties/miscfixes2/+merge/92611
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~evfool/software-properties/miscfixes2 into lp:software-properties.