[Merge] lp:~andrea.corbellini/software-properties/fix-621977-1 into lp:software-properties

Andrea Corbellini corbellini.andrea at gmail.com
Fri Dec 14 15:06:26 UTC 2012


Andrea Corbellini has proposed merging lp:~andrea.corbellini/software-properties/fix-621977-1 into lp:software-properties.

Requested reviews:
  Ubuntu Core Development Team (ubuntu-core-dev)

For more details, see:
https://code.launchpad.net/~andrea.corbellini/software-properties/fix-621977-1/+merge/139919

This is an updated version of my previous merge proposal:

  https://code.launchpad.net/~andrea.corbellini/software-properties/fix-621977/+merge/134815

This branch fixes bug #621977 in the following way:

1. deb-src lines are added, but commented out, so that Software Properties still lets you enable them later;

2. a new -s, --enable-source command line option is added so that you can add uncommented deb-src line with a single command;

Also:

3. when removing a source entry, all related deb-src lines are automatically removed.

I fixed the tests to work with the new code. test_dbus.test_updates_automation fails, but it also fails in trunk.

The point #3 (automatically remove deb-src entries) is required to do a "clean" job by default. Having deb-src lines without correspective deb lines makes sense, however it doesn't make much sense in most situations.

It'd be useful to expose via the DBus API the new parameters enable_source_code (of add_source_from_line) and remove_source_code (from remove_source). However, modifying the signature of the existing DBus methods will break backward compatibility. I suggest adding new methods for that. If you like the idea, I can create a bug task and work on it.
-- 
https://code.launchpad.net/~andrea.corbellini/software-properties/fix-621977-1/+merge/139919
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~andrea.corbellini/software-properties/fix-621977-1 into lp:software-properties.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 5367 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20121214/b17993ba/attachment.diff>


More information about the Ubuntu-reviews mailing list