[Merge] lp:~pwlars/auto-upgrade-testing/no-fail-conffiles into lp:auto-upgrade-testing
Michael Vogt
michael.vogt at ubuntu.com
Thu Dec 6 08:58:17 UTC 2012
On Wed, Dec 05, 2012 at 05:29:21PM -0000, Paul Larson wrote:
> Paul Larson has proposed merging lp:~pwlars/auto-upgrade-testing/no-fail-conffiles into lp:auto-upgrade-testing.
>
> Requested reviews:
> Auto Upgrade Testing Developers (auto-upgrade-testing-dev)
>
> For more details, see:
> https://code.launchpad.net/~pwlars/auto-upgrade-testing/no-fail-conffiles/+merge/138263
>
> Obsolete conffiles are messy, but are typically treated as lowest of low
> priority when it comes to bugs. Furthermore, especially on old releases,
> we have *lots* of failures that would take a considerable amount of time
> to track every single day, with little chance of becoming important
> enough to fix. I'd like to propose that we still generate the list of obsolete
> conffiles with the hopes of putting it in a report somewhere that
> people can see, but quit treating it as an error in the upgrade test
> runs.
I agree with this reasoning, its not a very important class of
problem. I know that it extends the scope of the MP so feel free to
reject the idea for now, but I would love to get a "warnings" category
in addition to "ok" and "fail". I'm not sure if jenkins supports this,
but it seems like it would be natural fit for this class of issue.
Cheers,
Michael
> --
> https://code.launchpad.net/~pwlars/auto-upgrade-testing/no-fail-conffiles/+merge/138263
> Your team Auto Upgrade Testing Developers is requested to review the proposed merge of lp:~pwlars/auto-upgrade-testing/no-fail-conffiles into lp:auto-upgrade-testing.
> === modified file 'share/post_upgrade_tests/test_conffiles.py'
> --- share/post_upgrade_tests/test_conffiles.py 2012-09-11 16:13:58 +0000
> +++ share/post_upgrade_tests/test_conffiles.py 2012-12-05 17:28:21 +0000
> @@ -50,9 +50,6 @@
> if test_output:
> with open(output_file, 'w') as f:
> print >>f, test_output
> - self.assertFalse(test_output,
> - 'Obsolete config file found. Check log file \'%s\'' %
> - output_file)
>
> def test_dpkgdist(self):
> '''Check for existence of *.dpkg-dist files'''
>
--
https://code.launchpad.net/~pwlars/auto-upgrade-testing/no-fail-conffiles/+merge/138263
Your team Auto Upgrade Testing Developers is requested to review the proposed merge of lp:~pwlars/auto-upgrade-testing/no-fail-conffiles into lp:auto-upgrade-testing.
More information about the Ubuntu-reviews
mailing list