[Merge] lp:~bulldog98/kubuntu-packaging/kate into lp:~kubuntu-packagers/kubuntu-packaging/kate

Philip Muškovac yofel at gmx.net
Fri Sep 2 20:16:23 UTC 2011


Review: Needs Fixing
- You didn't commit your changes in debian/control

- doing a local rebuild shows:
dpkg-gensymbols: warning: debian/libkatepartinterfaces4/DEBIAN/symbols doesn't match completely debian/libkatepartinterfaces4.symbols
--- debian/libkatepartinterfaces4.symbols (libkatepartinterfaces4_4:4.7.1-0ubuntu1~ppa1_amd64)
+++ dpkg-gensymbolsnW44lA       2011-09-02 20:09:57.505534496 +0000
@@ -77,7 +77,8 @@
  _ZN12KateDocument10removeTextERKN11KTextEditor5RangeEb at Base 4:4.6.90
  _ZN12KateDocument10removeViewEPN11KTextEditor4ViewE at Base 4:4.6.90
  _ZN12KateDocument10searchTextERKN11KTextEditor5RangeERK7QString6QFlagsINS0_6Search17SearchOptionsEnumEE at Base 4:4.6.90
- _ZN12KateDocument10setDocNameE7QString at Base 4:4.6.90
+#MISSING: 4:4.7.1-0ubuntu1~ppa1# _ZN12KateDocument10setDocNameE7QString at Base 4:4.6.90
+ _ZN12KateDocument10setDocNameERK7QString at Base 4:4.7.1-0ubuntu1~ppa1
  _ZN12KateDocument10simpleModeEv at Base 4:4.6.90
  _ZN12KateDocument11configValueERK7QString at Base 4:4.6.90
  _ZN12KateDocument11foldingTreeEv at Base 4:4.6.90
@@ -95,6 +96,7 @@
  _ZN12KateDocument11setModifiedEb at Base 4:4.6.90
  _ZN12KateDocument11setWordWrapEb at Base 4:4.6.90
  _ZN12KateDocument11undoChangedEv at Base 4:4.6.90
+ _ZN12KateDocument11undoManagerEv at Base 4:4.7.1-0ubuntu1~ppa1
  _ZN12KateDocument12bomSetByUserEv at Base 4:4.6.90
  _ZN12KateDocument12createDigestER10QByteArray at Base 4:4.6.90
  _ZN12KateDocument12dialogParentEv at Base 4:4.6.90

Please investigate why that symbol has changed, if public please hit the person that broke the ABI, if private just update the symbols file.

- maybe mention that you updated kate-data.install in debian/changelog
-- 
https://code.launchpad.net/~bulldog98/kubuntu-packaging/kate/+merge/73881
Your team Kubuntu Packagers is subscribed to branch lp:~kubuntu-packagers/kubuntu-packaging/kate.



More information about the Ubuntu-reviews mailing list